[mlpack-git] [mlpack] Bugfix #350 and some fixes in RStarTreeSplit and XTreeSplit (#556)

[lozhnikov]

XTreeSplit::InsertNodeIntoTree uses std::vector::push_back which increases the size of children vector.

bestAreaIndexOnBestAxis and bestOverlapIndexOnBestAxis should not be redefined in SplitNonLeafNode.

Otherwise the global variables will be equal 0.
You can view, comment on, or merge this pull request online at:

  https://github.com/mlpack/mlpack/pull/556

-- Commit Summary --

  * Fix invalid memory access during XTreeSplit #350
  * Fix redefinition in RStarTreeSplit::SplitNonLeafNode.
  * Update XTreeSplit API according to recent RStarTreeSplit API

-- File Changes --

    M src/mlpack/core/tree/rectangle_tree/r_star_tree_split_impl.hpp (8)
    M src/mlpack/core/tree/rectangle_tree/typedef.hpp (12)
    M src/mlpack/core/tree/rectangle_tree/x_tree_split.hpp (7)
    M src/mlpack/core/tree/rectangle_tree/x_tree_split_impl.hpp (128)
    M src/mlpack/tests/rectangle_tree_test.cpp (18)

-- Patch Links --

https://github.com/mlpack/mlpack/pull/556.patch
https://github.com/mlpack/mlpack/pull/556.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/556
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160308/17d1eaaa/attachment.html>