[mlpack-git] [mlpack] Bugfix #350 and some fixes in RStarTreeSplit and XTreeSplit (#556)
Ryan Curtin
notifications at github.com
Tue Mar 8 21:55:10 EST 2016
Thanks for the contribution. One of my concerns is that you are using the `RTreeDescentHeuristic` class instead of the `XTreeDescentHeuristic` class, which wasn't ever implemented (it was an unfinished GSoC project from 2014). This is only doable if the X-tree (as specified in the paper) uses the same descent heuristic as the original R tree. Do you know if that's the case?
Thanks for the RStarTreeSplit fixes too, those must have been oversights when I was refactoring.
---
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/556#issuecomment-194089749
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160308/9da3c655/attachment.html>
More information about the mlpack-git
mailing list