<p>XTreeSplit::InsertNodeIntoTree uses std::vector::push_back which increases the size of children vector.</p>

<p>bestAreaIndexOnBestAxis and bestOverlapIndexOnBestAxis should not be redefined in SplitNonLeafNode.</p>

<p>Otherwise the global variables will be equal 0.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>&nbsp;&nbsp;<a href='https://github.com/mlpack/mlpack/pull/556'>https://github.com/mlpack/mlpack/pull/556</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Fix invalid memory access during XTreeSplit #350</li>
  <li>Fix redefinition in RStarTreeSplit::SplitNonLeafNode.</li>
  <li>Update XTreeSplit API according to recent RStarTreeSplit API</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/556/files#diff-0">src/mlpack/core/tree/rectangle_tree/r_star_tree_split_impl.hpp</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/556/files#diff-1">src/mlpack/core/tree/rectangle_tree/typedef.hpp</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/556/files#diff-2">src/mlpack/core/tree/rectangle_tree/x_tree_split.hpp</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/556/files#diff-3">src/mlpack/core/tree/rectangle_tree/x_tree_split_impl.hpp</a>
    (128)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/556/files#diff-4">src/mlpack/tests/rectangle_tree_test.cpp</a>
    (18)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/mlpack/mlpack/pull/556.patch'>https://github.com/mlpack/mlpack/pull/556.patch</a></li>
  <li><a href='https://github.com/mlpack/mlpack/pull/556.diff'>https://github.com/mlpack/mlpack/pull/556.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br>Reply to this email directly or <a href="https://github.com/mlpack/mlpack/pull/556">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFDoG8UGvFjzvs59HugiJOc4Ht4YZks5prg8XgaJpZM4HsSai.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/556"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>