[mlpack-git] [mlpack/mlpack] Hilbert R tree (#664)

Ryan Curtin notifications at github.com
Thu Jun 2 15:44:35 EDT 2016


> +    tree->NullifyData();
> +    // Because this was a leaf node, numChildren must be 0.
> +    tree->Children()[(tree->NumChildren())++] = copy;
> +    HilbertRTreeSplit::SplitLeafNode(copy,relevels);
> +    return;
> +  }
> +
> +  TreeType *parent = tree->Parent();
> +
> +  size_t iTree = 0;
> +  for(iTree = 0;parent->Children()[iTree] != tree; iTree++);
> +
> +  // Try to find splitOrder cooperating siblings in order to redistribute
> +  // points among them and avoid split.
> +  size_t firstSibling,lastSibling;
> +  if(FindCooperatingSiblings(parent,iTree,firstSibling,lastSibling))

Minor style issue, can you make this line:
```
if (FindCooperatingSiblings(parent, iTree, firstSibling, lastSibling))
```
(horizontal whitespace is what I'm focused on there)

I think this happens many other places, could you fix those too please?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/664/files/ab890dff6b4b617b5309af53950c6cac97d994d6#r65605456
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160602/fedef284/attachment-0001.html>


More information about the mlpack-git mailing list