[mlpack-git] [mlpack/mlpack] Hilbert R tree (#664)

[Ryan Curtin]

> @@ -91,8 +93,8 @@ class RectangleTree
>    std::vector<size_t> points;
>    //! The local dataset
>    MatType* localDataset;
> -  //! The class that performs the split of the node.
> -  SplitType<RectangleTree> split;
> +  //! A tree-specific information
> +  AuxiliaryInformationType<RectangleTree> *auxiliaryInfo;

Are you sure we want to allocate this on the heap?  We then have to manage the memory and make sure it is valid.  I think usually the `AuxiliaryInformationType` classes will be small (looks like the one for the Hilbert R tree will be maybe 32 bytes), so I don't know if this is worth doing.  (A few more comments about the AuxiliaryInformationType are coming but I have to step out, so it may be a little while until I am able to write those comments.)

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/664/files/ab890dff6b4b617b5309af53950c6cac97d994d6#r65606357
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160602/a87647e9/attachment.html>