[mlpack-git] [mlpack/mlpack] Hilbert R tree (#664)

[Ryan Curtin]

> +   * @param src The node from which the information is being copied.
> +   */
> +  template<typename TreeType>
> +  void Copy(TreeType *dst, TreeType *src);
> +
> +  /**
> +   * Update the largest Hilbert value and the local dataset.
> +   * The children of the node (or the points that the node contains) should be
> +   * arranged according to their Hilbert values.
> +   * @param node The node in which the information should be updated.
> +   */
> +  template<typename TreeType>
> +  void UpdateLargestValue(TreeType *node);
> +
> +  //! Copy the largest Hilbert value.
> +  DiscreteHilbertValue operator = (const DiscreteHilbertValue &val);

This a very minor style change, but can you go with `const A& b` instead of `const A &b`?  I don't think this is written in the style guide but it's what's done in the rest of the code.  I've updated the style guide:
https://github.com/mlpack/mlpack/wiki/DesignGuidelines#pointers-and-reference-placement

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/664/files/ab890dff6b4b617b5309af53950c6cac97d994d6#r65603877
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160602/63b39059/attachment-0001.html>