<p>In <a href="https://github.com/mlpack/mlpack/pull/664#discussion_r65603877">src/mlpack/core/tree/rectangle_tree/discrete_hilbert_value.hpp</a>:</p>
<pre style='color:#555'>> + * @param src The node from which the information is being copied.
> + */
> + template<typename TreeType>
> + void Copy(TreeType *dst, TreeType *src);
> +
> + /**
> + * Update the largest Hilbert value and the local dataset.
> + * The children of the node (or the points that the node contains) should be
> + * arranged according to their Hilbert values.
> + * @param node The node in which the information should be updated.
> + */
> + template<typename TreeType>
> + void UpdateLargestValue(TreeType *node);
> +
> + //! Copy the largest Hilbert value.
> + DiscreteHilbertValue operator = (const DiscreteHilbertValue &val);
</pre>
<p>This a very minor style change, but can you go with <code>const A& b</code> instead of <code>const A &b</code>? I don't think this is written in the style guide but it's what's done in the rest of the code. I've updated the style guide:<br>
<a href="https://github.com/mlpack/mlpack/wiki/DesignGuidelines#pointers-and-reference-placement">https://github.com/mlpack/mlpack/wiki/DesignGuidelines#pointers-and-reference-placement</a></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/664/files/ab890dff6b4b617b5309af53950c6cac97d994d6#r65603877">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFMn_213uMfBNitl_u29LGTDIhGBzks5qHzAigaJpZM4IrlzT">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFDcYxU6NWLGpNlLoSOQX0Gb0zwqCks5qHzAigaJpZM4IrlzT.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/664/files/ab890dff6b4b617b5309af53950c6cac97d994d6#r65603877"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>