[mlpack-git] [mlpack/mlpack] Refactor PCA class: able to use different decomposition techniques (exact, randomized, QUIC SVD). (#716)

Ryan Curtin notifications at github.com
Mon Jul 4 19:44:15 EDT 2016


This is nice, I like the changes. My only thought is, this breaks reverse compatibility---now any code that calls the `PCA` class must be changed to `PCA<>`. When I refactored the `Range` class to accept different template types, I instead renamed it to `RangeType<>` and then typedef'ed `Range` to `RangeType<double>` to avoid breaking reverse compatibility, and made a note in the documentation and in HISTORY.txt about the change and that in mlpack 3.0.0 we would change the name of `RangeType` to `Range` and remove the typedef. Maybe we could do the same here?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/716#issuecomment-230364158
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160704/9250948a/attachment.html>


More information about the mlpack-git mailing list