<p>This is nice, I like the changes. My only thought is, this breaks reverse compatibility---now any code that calls the <code>PCA</code> class must be changed to <code>PCA<></code>. When I refactored the <code>Range</code> class to accept different template types, I instead renamed it to <code>RangeType<></code> and then typedef'ed <code>Range</code> to <code>RangeType<double></code> to avoid breaking reverse compatibility, and made a note in the documentation and in HISTORY.txt about the change and that in mlpack 3.0.0 we would change the name of <code>RangeType</code> to <code>Range</code> and remove the typedef. Maybe we could do the same here?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/716#issuecomment-230364158">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFJkM1krgLMRSThEHJBrfbcOE1-DWks5qSZrPgaJpZM4JEUwr">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFO4mbwzA7eoJsal1e4IWBqfdOBq_ks5qSZrPgaJpZM4JEUwr.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/716#issuecomment-230364158"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>