[mlpack-git] [mlpack/mlpack] Refactor PCA class: able to use different decomposition techniques (exact, randomized, QUIC SVD). (#716)

Ryan Curtin notifications at github.com
Mon Jul 4 19:39:17 EDT 2016


>    {
> -    varRetained = p.Apply(dataset, newDimension);
> +    RunPCA<RandomizedSVDPolicy>(dataset, newDimension, scale, varToRetain);
> +  }
> +  else if(decompositionMethod == "quic")
> +  {
> +    RunPCA<QUICSVDPolicy>(dataset, newDimension, scale, varToRetain);
>    }

I think if a user picks an invalid decomposition policy, no error is issued? I am not sure if I am reading this right, but if so I think we should add an else to catch the error. :)

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/716/files/1d675d4febd84d3210a10c6cc18efa1bb1558045#r69495836
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160704/01ef4f65/attachment.html>


More information about the mlpack-git mailing list