<p>In <a href="https://github.com/mlpack/mlpack/pull/716#discussion_r69495836">src/mlpack/methods/pca/pca_main.cpp</a>:</p>
<pre style='color:#555'>&gt;    {
&gt; -    varRetained = p.Apply(dataset, newDimension);
&gt; +    RunPCA&lt;RandomizedSVDPolicy&gt;(dataset, newDimension, scale, varToRetain);
&gt; +  }
&gt; +  else if(decompositionMethod == &quot;quic&quot;)
&gt; +  {
&gt; +    RunPCA&lt;QUICSVDPolicy&gt;(dataset, newDimension, scale, varToRetain);
&gt;    }
</pre>
<p>I think if a user picks an invalid decomposition policy, no error is issued? I am not sure if I am reading this right, but if so I think we should add an else to catch the error. :)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/716/files/1d675d4febd84d3210a10c6cc18efa1bb1558045#r69495836">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFO7qYOvCCie-K2RCtD32k_RohSnuks5qSZmlgaJpZM4JEUwr">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFNc3-DW1NhXCL6P3pVPtqSep6irHks5qSZmlgaJpZM4JEUwr.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/716/files/1d675d4febd84d3210a10c6cc18efa1bb1558045#r69495836"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>