[mlpack-git] [mlpack/mlpack] Universal B tree implementation (#746)

[Ryan Curtin]

Ah, yeah, Github doesn't seem to send notifications when comments are updated.

I think either strategy for the `PerformSplit()` refactoring can work, but what I wanted to avoid was a specialization for `UBTreeSplit`.  You can definitely add a static boolean and use that to determine whether a function like `PerformSplit()` is called.  Then basically the "default" behavior is that the split is performed if `SplitType::NeedsPerformSplit` is true; otherwise the `SplitType` itself is responsible for rearranging the dataset.  As long as we document how it works, I think either way is fine, so pick whichever seems best to you.  If I did it, I'd probably lean toward the first idea of the standalone function that most `SplitType`s call, but my preference is pretty minimal.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/746#issuecomment-242547220
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160825/5ce1ab72/attachment.html>