[mlpack-git] [mlpack/mlpack] Universal B tree implementation (#746)

lozhnikov notifications at github.com
Thu Aug 25 16:59:34 EDT 2016

The idea with the ordering of dimensions is really interesting, I didn't think about that. 

I'll do the refactoring. I edited my comment about `oldFromNew`, I am not sure that github sends the notification.

> P.S. Oh.. I overlooked that `oldFromNew` is initialized in the constructor of `BinarySpaceTree`. You are right.

> P.P.S. Do you mean a function like `SplitType::RearrangeDataset()`? (i.e. a function that rearranges the dataset before the split, the function do nothing in other binary space trees). We could add a check to `PerformSplit()` if we needn't invoke that (e.g. `static bool SplitType::NeedPerformSplit`). This is another solution of the problem with the overload. What do you think about that?

What do you think about this idea? Maybe it is better than calling `SplitType::PerformSplit()`.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160825/4bcd0202/attachment.html>

More information about the mlpack-git mailing list