<p>Ah, yeah, Github doesn't seem to send notifications when comments are updated.</p>

<p>I think either strategy for the <code>PerformSplit()</code> refactoring can work, but what I wanted to avoid was a specialization for <code>UBTreeSplit</code>.  You can definitely add a static boolean and use that to determine whether a function like <code>PerformSplit()</code> is called.  Then basically the "default" behavior is that the split is performed if <code>SplitType::NeedsPerformSplit</code> is true; otherwise the <code>SplitType</code> itself is responsible for rearranging the dataset.  As long as we document how it works, I think either way is fine, so pick whichever seems best to you.  If I did it, I'd probably lean toward the first idea of the standalone function that most <code>SplitType</code>s call, but my preference is pretty minimal.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/746#issuecomment-242547220">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFGaHkcWqTUd70uqlu3CFBVHyLx2jks5qjglfgaJpZM4JZrEi">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFGPDLpBDUSSZkfq7f2uQmU4gCp6-ks5qjglfgaJpZM4JZrEi.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/746#issuecomment-242547220"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #746: Ah, yeah, Github doesn't seem to send notifications when comments are updated.\r\n\r\nI think either strategy for the `PerformSplit()` refactoring can work, but what I wanted to avoid was a specialization for `UBTreeSplit`.  You can definitely add a static boolean and use that to determine whether a function like `PerformSplit()` is called.  Then basically the \"default\" behavior is that the split is performed if `SplitType::NeedsPerformSplit` is true; otherwise the `SplitType` itself is responsible for rearranging the dataset.  As long as we document how it works, I think either way is fine, so pick whichever seems best to you.  If I did it, I'd probably lean toward the first idea of the standalone function that most `SplitType`s call, but my preference is pretty minimal."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/746#issuecomment-242547220"}}}</script>