<p>The idea with the ordering of dimensions is really interesting, I didn't think about that. </p>

<p>I'll do the refactoring. I edited my comment about <code>oldFromNew</code>, I am not sure that github sends the notification.</p>

<blockquote>
<p>P.S. Oh.. I overlooked that <code>oldFromNew</code> is initialized in the constructor of <code>BinarySpaceTree</code>. You are right.</p>

<p>P.P.S. Do you mean a function like <code>SplitType::RearrangeDataset()</code>? (i.e. a function that rearranges the dataset before the split, the function do nothing in other binary space trees). We could add a check to <code>PerformSplit()</code> if we needn't invoke that (e.g. <code>static bool SplitType::NeedPerformSplit</code>). This is another solution of the problem with the overload. What do you think about that?</p>
</blockquote>

<p>What do you think about this idea? Maybe it is better than calling <code>SplitType::PerformSplit()</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/746#issuecomment-242538703">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFArVUIJYhVCIVz1zkjsHFHceFdMZks5qjgI2gaJpZM4JZrEi">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFL24V-wpuEZml4lJBexFirP2QqhJks5qjgI2gaJpZM4JZrEi.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/746#issuecomment-242538703"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@lozhnikov in #746: The idea with the ordering of dimensions is really interesting, I didn't think about that. \r\n\r\nI'll do the refactoring. I edited my comment about `oldFromNew`, I am not sure that github sends the notification.\r\n\r\n\u003e P.S. Oh.. I overlooked that `oldFromNew` is initialized in the constructor of `BinarySpaceTree`. You are right.\r\n\r\n\u003e P.P.S. Do you mean a function like `SplitType::RearrangeDataset()`? (i.e. a function that rearranges the dataset before the split, the function do nothing in other binary space trees). We could add a check to `PerformSplit()` if we needn't invoke that (e.g. `static bool SplitType::NeedPerformSplit`). This is another solution of the problem with the overload. What do you think about that?\r\n\r\nWhat do you think about this idea? Maybe it is better than calling `SplitType::PerformSplit()`."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/746#issuecomment-242538703"}}}</script>