[mlpack-git] [mlpack/mlpack] issue #787 - Replace `MinDistance(TreeType*)` with `MinDistance(TreeType&)` (#788)

Ryan Curtin notifications at github.com
Sat Sep 24 23:04:46 EDT 2016


rcurtin approved this pull request.

Hi there Anuraj,

Thanks for the contribution.  This looks good to me.  There are two more things to do though... if you like, you can do them, or I can do them:

 * Add your name to the contributors in `src/mlpack/core.hpp` and `COPYRIGHT.txt`
 * Update the documentation for the `TreeType` policy in `doc/policies/trees.hpp` (I forgot about this part earlier).

Let me know if you would or wouldn't like to do them and we can go from there. :)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/788#pullrequestreview-1445389
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160924/3031b38a/attachment.html>


More information about the mlpack-git mailing list