[mlpack-git] [mlpack/mlpack] issue #787 - Replace `MinDistance(TreeType*)` with `MinDistance(TreeType&)` (#788)

Anuraj Kanodia notifications at github.com
Tue Sep 20 06:13:39 EDT 2016


Changed functions in the Tree Type API to use references. Refactored all relevant files.
Functions changed:
```
ElemType MinDistance(const TreeType* other);
ElemType MaxDistance(const TreeType* other);
math::RangeType<ElemType> RangeDistance(const TreeType* other);
```


You can view, comment on, or merge this pull request online at:

  https://github.com/mlpack/mlpack/pull/788

-- Commit Summary --

  * binary_space_tree.hpp #787 fix
  * binary_space_tree_impl.hpp #787 fix
  * cover_tree.hpp #787 fix
  * binary_space_tree_impl.hpp #787 fix
  * cover_tree_impl.hpp #787 fix
  * function signature changed
  * minor refactoring
  * function signature changed
  * refactored src/mlpack/methods/*/ - updated MinDistance(), MaxDistance() and RangeDistance() calls

-- File Changes --

    M src/mlpack/core/tree/binary_space_tree/binary_space_tree.hpp (12)
    M src/mlpack/core/tree/binary_space_tree/binary_space_tree_impl.hpp (8)
    M src/mlpack/core/tree/cover_tree/cover_tree.hpp (12)
    M src/mlpack/core/tree/cover_tree/cover_tree_impl.hpp (38)
    M src/mlpack/core/tree/rectangle_tree/rectangle_tree.hpp (12)
    M src/mlpack/core/tree/rectangle_tree/rectangle_tree_impl.hpp (4)
    M src/mlpack/core/tree/spill_tree/spill_tree.hpp (12)
    M src/mlpack/methods/emst/dtb_rules_impl.hpp (2)
    M src/mlpack/methods/kmeans/dual_tree_kmeans_rules_impl.hpp (4)
    M src/mlpack/methods/neighbor_search/sort_policies/furthest_neighbor_sort_impl.hpp (6)
    M src/mlpack/methods/neighbor_search/sort_policies/nearest_neighbor_sort_impl.hpp (6)
    M src/mlpack/methods/range_search/range_search_rules_impl.hpp (2)

-- Patch Links --

https://github.com/mlpack/mlpack/pull/788.patch
https://github.com/mlpack/mlpack/pull/788.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/788
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160920/d6f4b077/attachment.html>


More information about the mlpack-git mailing list