[mlpack-git] [mlpack/mlpack] Density Estimation Tree made sparse-enabled (#802)

[Ryan Curtin]

> - I did already implemented SpMat sort - it is in another branch, but I haven't made tests, so I didn't make pull request.
> - The code in ExtractSplits is pretty close to that sorting, but with removed parts that we're not interested in.

That's really nice, would you like to put it in arma_extend.hpp?  I can help with that and also help write tests for it and then it can be submitted upstream.  For the code in `ExtractSplits()`, is it noticeably faster than the sparse matrix splitting code you wrote?  If the difference is very minimal I think it would be better to go with a simple strategy that does not need special code to handle sparse matrices---the `row_col_iterator` approach I proposed is nice for this reason: it is generic.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/802#issuecomment-256235577
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20161025/8c30e603/attachment.html>