<blockquote>
<ul>
<li>I did already implemented SpMat sort - it is in another branch, but I haven't made tests, so I didn't make pull request.</li>
<li>The code in ExtractSplits is pretty close to that sorting, but with removed parts that we're not interested in.</li>
</ul>
</blockquote>

<p>That's really nice, would you like to put it in arma_extend.hpp?  I can help with that and also help write tests for it and then it can be submitted upstream.  For the code in <code>ExtractSplits()</code>, is it noticeably faster than the sparse matrix splitting code you wrote?  If the difference is very minimal I think it would be better to go with a simple strategy that does not need special code to handle sparse matrices---the <code>row_col_iterator</code> approach I proposed is nice for this reason: it is generic.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/802#issuecomment-256235577">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFFmyECpZzrDz72JDJk4eVDmZf0i6ks5q3r8IgaJpZM4KZnsm">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFAqz_Wzy2YhUKmUY7mLfjZZFllGCks5q3r8IgaJpZM4KZnsm.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/802#issuecomment-256235577"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #802: \u003e - I did already implemented SpMat sort - it is in another branch, but I haven't made tests, so I didn't make pull request.\r\n\u003e - The code in ExtractSplits is pretty close to that sorting, but with removed parts that we're not interested in.\r\n\r\nThat's really nice, would you like to put it in arma_extend.hpp?  I can help with that and also help write tests for it and then it can be submitted upstream.  For the code in `ExtractSplits()`, is it noticeably faster than the sparse matrix splitting code you wrote?  If the difference is very minimal I think it would be better to go with a simple strategy that does not need special code to handle sparse matrices---the `row_col_iterator` approach I proposed is nice for this reason: it is generic.\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/802#issuecomment-256235577"}}}</script>