[mlpack-git] [mlpack/mlpack] Integrate DTree into BinarySpaceTree (#227)

[Ivan Georgiev]

After about two days of investigation of `BinarySpaceTree` I've given up doing that merge, because of these, few reasons:

- `BinarySpaceTree` is both quite universal, but in the same time - pretty much bound to tasks like kNN, etc. For example, the split criteria is solely bound to the `Bound` type, i.e. the space boundaries, which is not exactly the case in DET, where the split is based on a broader term of _error_.
- Also, there is a good amount of methods, related to this approach, and having nothing to do with DET's task (`*Distance`, `*Descendants`, etc.). In the same time methods a-la `ComputeValue` are missing as a concept.
- Some of the template arguments of `BinarySpaceTree` class are really making it pretty weird to provide necessary classes, being templated themselves - I know this is because of ease of providing these arguments.

So, at the end of the day, I've realized it is more like a "hack", rather than different instantiation - the value that `BinarySpaceTree` would bring would be comparably small to the custom implementation that `DTree` requires.

However, I've made the the whole DET algorithm implementation sparse-matrix enabled (Pull Request #802), so it shouldn't be difficult for this merge to happen, should someone wants to do it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/issues/227#issuecomment-254470448
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20161018/d51430d2/attachment.html>