[mlpack-git] [mlpack/mlpack] fix performance issue--forgot to move name parameters (#653)

stereomatchingkiss notifications at github.com
Thu May 26 11:21:30 EDT 2016


As the title said, std::make_tuple do not need to move, because the compiler will 

1 : directly construct the tuple when it can
2 : move the tuple if case 1 can not be done

move is good, but direct construct is even better, use std::move to move the tuple would forbid the compiler to do the optimization
You can view, comment on, or merge this pull request online at:

  https://github.com/mlpack/mlpack/pull/653

-- Commit Summary --

  * fix performance issue--forgot to move name parameters

-- File Changes --

    M src/mlpack/core/data/split_data.hpp (5)

-- Patch Links --

https://github.com/mlpack/mlpack/pull/653.patch
https://github.com/mlpack/mlpack/pull/653.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/653
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160526/b6a69cfa/attachment.html>


More information about the mlpack-git mailing list