<p>As the title said, std::make_tuple do not need to move, because the compiler will </p>
<p>1 : directly construct the tuple when it can<br>
2 : move the tuple if case 1 can not be done</p>
<p>move is good, but direct construct is even better, use std::move to move the tuple would forbid the compiler to do the optimization</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/mlpack/mlpack/pull/653'>https://github.com/mlpack/mlpack/pull/653</a></p>
<h4>Commit Summary</h4>
<ul>
<li>fix performance issue--forgot to move name parameters</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/653/files#diff-0">src/mlpack/core/data/split_data.hpp</a>
(5)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/mlpack/mlpack/pull/653.patch'>https://github.com/mlpack/mlpack/pull/653.patch</a></li>
<li><a href='https://github.com/mlpack/mlpack/pull/653.diff'>https://github.com/mlpack/mlpack/pull/653.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly or <a href="https://github.com/mlpack/mlpack/pull/653">view it on GitHub</a><img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFBLrIUoFAOyukMcFnONA7AOEMiRdks5qFbp6gaJpZM4Inp5I.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/653"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>