[mlpack-git] [mlpack] CMake blockend arguments (#586)

ajjl notifications at github.com
Mon Mar 21 16:53:14 EDT 2016


This addresses issue #585 and is a continuation of issue #583 ( pull request #584 )

Previously CMake block termination commands were required to have arguments
matching the command starting the block. This is no longer necessary and not
the preferred style. This type of change has been implemented in other open
source projects such as: ITK, vxl, and BRAINSTools. It is the preferred style
for KDE. Consistent style practices help improve readability and
maintainability of code.
You can view, comment on, or merge this pull request online at:

  https://github.com/mlpack/mlpack/pull/586

-- Commit Summary --

  * Converts CMake commands to lower case
  * Removes CMake block termination arguments

-- File Changes --

    M CMake/ARMA_FindACML.cmake (38)
    M CMake/ARMA_FindACMLMP.cmake (38)
    M CMake/ARMA_FindARPACK.cmake (36)
    M CMake/ARMA_FindBLAS.cmake (40)
    M CMake/ARMA_FindCBLAS.cmake (42)
    M CMake/ARMA_FindCLAPACK.cmake (44)
    M CMake/ARMA_FindLAPACK.cmake (40)
    M CMake/ARMA_FindMKL.cmake (80)
    M CMake/ARMA_FindOpenBLAS.cmake (38)
    M CMake/CreateArmaConfigInfo.cmake (22)
    M CMake/CreateGitVersionHeader.cmake (8)
    M CMake/FindArmadillo.cmake (41)
    M CMake/FindBfd.cmake (2)
    M CMake/FindLibDL.cmake (4)
    M CMake/FindMatlabMex.cmake (84)
    M CMake/ModifyMatlabPathdef.cmake (4)
    M CMake/TargetDistclean.cmake (8)
    M CMakeLists.txt (72)
    M src/mlpack/CMakeLists.txt (10)
    M src/mlpack/bindings/CMakeLists.txt (2)
    M src/mlpack/bindings/matlab/CMakeLists.txt (16)

-- Patch Links --

https://github.com/mlpack/mlpack/pull/586.patch
https://github.com/mlpack/mlpack/pull/586.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/586
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160321/1d6eac0e/attachment.html>


More information about the mlpack-git mailing list