<p>This addresses issue <a href="https://github.com/mlpack/mlpack/issues/585" class="issue-link js-issue-link" data-url="https://github.com/mlpack/mlpack/issues/585" data-id="142455725" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#585</a> and is a continuation of issue <a href="https://github.com/mlpack/mlpack/issues/583" class="issue-link js-issue-link" data-url="https://github.com/mlpack/mlpack/issues/583" data-id="142432099" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#583</a> ( pull request <a href="https://github.com/mlpack/mlpack/pull/584" class="issue-link js-issue-link" data-url="https://github.com/mlpack/mlpack/issues/584" data-id="142436352" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#584</a> )</p>

<p>Previously CMake block termination commands were required to have arguments<br>
matching the command starting the block. This is no longer necessary and not<br>
the preferred style. This type of change has been implemented in other open<br>
source projects such as: ITK, vxl, and BRAINSTools. It is the preferred style<br>
for KDE. Consistent style practices help improve readability and<br>
maintainability of code.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>&nbsp;&nbsp;<a href='https://github.com/mlpack/mlpack/pull/586'>https://github.com/mlpack/mlpack/pull/586</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Converts CMake commands to lower case</li>
  <li>Removes CMake block termination arguments</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-0">CMake/ARMA_FindACML.cmake</a>
    (38)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-1">CMake/ARMA_FindACMLMP.cmake</a>
    (38)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-2">CMake/ARMA_FindARPACK.cmake</a>
    (36)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-3">CMake/ARMA_FindBLAS.cmake</a>
    (40)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-4">CMake/ARMA_FindCBLAS.cmake</a>
    (42)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-5">CMake/ARMA_FindCLAPACK.cmake</a>
    (44)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-6">CMake/ARMA_FindLAPACK.cmake</a>
    (40)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-7">CMake/ARMA_FindMKL.cmake</a>
    (80)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-8">CMake/ARMA_FindOpenBLAS.cmake</a>
    (38)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-9">CMake/CreateArmaConfigInfo.cmake</a>
    (22)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-10">CMake/CreateGitVersionHeader.cmake</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-11">CMake/FindArmadillo.cmake</a>
    (41)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-12">CMake/FindBfd.cmake</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-13">CMake/FindLibDL.cmake</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-14">CMake/FindMatlabMex.cmake</a>
    (84)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-15">CMake/ModifyMatlabPathdef.cmake</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-16">CMake/TargetDistclean.cmake</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-17">CMakeLists.txt</a>
    (72)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-18">src/mlpack/CMakeLists.txt</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-19">src/mlpack/bindings/CMakeLists.txt</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/586/files#diff-20">src/mlpack/bindings/matlab/CMakeLists.txt</a>
    (16)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/mlpack/mlpack/pull/586.patch'>https://github.com/mlpack/mlpack/pull/586.patch</a></li>
  <li><a href='https://github.com/mlpack/mlpack/pull/586.diff'>https://github.com/mlpack/mlpack/pull/586.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly or <a href="https://github.com/mlpack/mlpack/pull/586">view it on GitHub</a><img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFJbHVUOFuoHDNTWxyIKs3PDauIOrks5pvwU6gaJpZM4H1jWP.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/586"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>