[mlpack-git] [mlpack] WIP: Refactor LRSDP to support more general linear constraints (#580)

[Ryan Curtin]

> +
> +  //! Return the vector of A matrices.
> +  const std::vector<MatrixType>& A() const { return _a; }
> +
> +  //! Modify the vector of A matrices.
> +  std::vector<MatrixType>& A() { return _a; }
> +
> +  //! Return the vector of b values.
> +  const arma::vec& B() const { return _b; }
> +  
> +  //! Modify the vector of b values.
> +  arma::vec& B() { return _b; }
> +
> +private:
> +  std::vector<MatrixType> _a;
> +  arma::vec _b;

Could you change these member names to just `a` and `b` please?  See https://github.com/mlpack/mlpack/wiki/DesignGuidelines#naming-conventions (this comment applies in other places too, I think).

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/580/files/1de2fb1ed30fe9007ecb6c7de4d2b91f7184b9f6#r56503781
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160317/ffffab67/attachment.html>