<p>In <a href="https://github.com/mlpack/mlpack/pull/580#discussion_r56503781">src/mlpack/core/optimizers/sdp/linear_constraint.hpp</a>:</p>
<pre style='color:#555'>> +
> + //! Return the vector of A matrices.
> + const std::vector<MatrixType>& A() const { return _a; }
> +
> + //! Modify the vector of A matrices.
> + std::vector<MatrixType>& A() { return _a; }
> +
> + //! Return the vector of b values.
> + const arma::vec& B() const { return _b; }
> +
> + //! Modify the vector of b values.
> + arma::vec& B() { return _b; }
> +
> +private:
> + std::vector<MatrixType> _a;
> + arma::vec _b;
</pre>
<p>Could you change these member names to just <code>a</code> and <code>b</code> please? See <a href="https://github.com/mlpack/mlpack/wiki/DesignGuidelines#naming-conventions">https://github.com/mlpack/mlpack/wiki/DesignGuidelines#naming-conventions</a> (this comment applies in other places too, I think).</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly or <a href="https://github.com/mlpack/mlpack/pull/580/files/1de2fb1ed30fe9007ecb6c7de4d2b91f7184b9f6#r56503781">view it on GitHub</a><img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFIX3EnND-nkFq0Tw-z7bfj9Q4YhBks5puVi4gaJpZM4Hyp0C.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/580/files/1de2fb1ed30fe9007ecb6c7de4d2b91f7184b9f6#r56503781"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>