[mlpack-git] [mlpack/mlpack] Implementation of Multiprobe LSH (#691)

Ryan Curtin notifications at github.com
Mon Jun 27 16:08:41 EDT 2016


> @@ -477,6 +933,23 @@ void LSHSearch<SortPolicy>::Search(const arma::mat& querySet,
>    if (k == 0)
>      return;
>  
> +  // If the user requested more than the available number of additional probing
> +  // bins, set Teffective to maximum T. Maximum T is 2^numProj - 1
> +  size_t Teffective = T;
> +  if (T > ( (size_t) ( (1 << numProj) - 1) ) )
> +  {
> +    Teffective = ( 1 << numProj ) - 1;

There are a bunch of extra spaces in these three lines:

```
if (T > ((size_t) ((1 << numProj) - 1)))
{
  Teffective = (1 << numProj) - 1;
```

Technically variables should have names that start with lowercase letters, so I would have gone with `t` and `effectiveT` instead.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/691/files/71eda99e207a9b91581504e11a9e14d38838bc9f#r68646321
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160627/6a765868/attachment.html>


More information about the mlpack-git mailing list