<p>In <a href="https://github.com/mlpack/mlpack/pull/691#discussion_r68646321">src/mlpack/methods/lsh/lsh_search_impl.hpp</a>:</p>
<pre style='color:#555'>> @@ -477,6 +933,23 @@ void LSHSearch<SortPolicy>::Search(const arma::mat& querySet,
> if (k == 0)
> return;
>
> + // If the user requested more than the available number of additional probing
> + // bins, set Teffective to maximum T. Maximum T is 2^numProj - 1
> + size_t Teffective = T;
> + if (T > ( (size_t) ( (1 << numProj) - 1) ) )
> + {
> + Teffective = ( 1 << numProj ) - 1;
</pre>
<p>There are a bunch of extra spaces in these three lines:</p>
<pre><code>if (T > ((size_t) ((1 << numProj) - 1)))
{
Teffective = (1 << numProj) - 1;
</code></pre>
<p>Technically variables should have names that start with lowercase letters, so I would have gone with <code>t</code> and <code>effectiveT</code> instead.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/691/files/71eda99e207a9b91581504e11a9e14d38838bc9f#r68646321">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFFCvRXGdrTckL0iO6LDK29rBFlfAks5qQC3JgaJpZM4IxQW5">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFAm5d8Pfqr3XCm3p6z0biVT1DQ8Mks5qQC3JgaJpZM4IxQW5.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/691/files/71eda99e207a9b91581504e11a9e14d38838bc9f#r68646321"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>