[mlpack-git] [mlpack/mlpack] DatasetMapper & Imputer (#694)

[Tham]

>    }
>  
>    /**
>    * This overload of Impute() lets users to define custom value that
>    * can be replaced with the target value.
>    */
> -  template <typename T>
> -  void Impute(const arma::Mat<T> &input,
> -              arma::Mat<T> &output,
> -              const std::string &targetValue,
> -              const T &customValue,
> +  void Impute(const arma::Mat<T>& input,

Maybe we could std::enable_if to specify which type of imputation are support by this function?Or static_assert?If it works, I think static_assert is a better choice, since the error messages should be more human friendly.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/694/files/da4e40981c40e171858f41de4e85e08af2c7e48d..d8618ec909005b0453f0a3803ac1e6cc5e588f1f#r68372328
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160624/f4d7f320/attachment.html>