<p>In <a href="https://github.com/mlpack/mlpack/pull/694#discussion_r68372328">src/mlpack/core/data/imputer.hpp</a>:</p>
<pre style='color:#555'>> }
>
> /**
> * This overload of Impute() lets users to define custom value that
> * can be replaced with the target value.
> */
> - template <typename T>
> - void Impute(const arma::Mat<T> &input,
> - arma::Mat<T> &output,
> - const std::string &targetValue,
> - const T &customValue,
> + void Impute(const arma::Mat<T>& input,
</pre>
<p>Maybe we could std::enable_if to specify which type of imputation are support by this function?Or static_assert?If it works, I think static_assert is a better choice, since the error messages should be more human friendly.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/694/files/da4e40981c40e171858f41de4e85e08af2c7e48d..d8618ec909005b0453f0a3803ac1e6cc5e588f1f#r68372328">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFLdLp_ElIIWaoNXHkJCyeXSpPpjpks5qO59qgaJpZM4I07W-">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFB71xH5XBbD7xvuF7Bwj0xXYmOkrks5qO59qgaJpZM4I07W-.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/694/files/da4e40981c40e171858f41de4e85e08af2c7e48d..d8618ec909005b0453f0a3803ac1e6cc5e588f1f#r68372328"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>