[mlpack-git] [mlpack/mlpack] Hilbert R tree (#664)

[Ryan Curtin]

> +  const arma::Col<HilbertElemType>* ValueToInsert() const
> +  { return valueToInsert; }
> +
> + private:
> +  //! The number of bits that we can store
> +  static constexpr size_t order = sizeof(HilbertElemType) * CHAR_BIT;
> +  //! The local dataset
> +  arma::Mat<HilbertElemType>* localDataset;
> +  //! Indicates that the node owns the local dataset
> +  bool ownsLocalDataset;
> +  //! The number of values in the local dataset
> +  size_t numValues;
> +  //! The Hilbert value of the point that is being inserted
> +  arma::Col<HilbertElemType>* valueToInsert;
> +  //! Indicates that the node owns the valueToInsert 
> +  bool ownsValueToInsert;

I read the code more and maybe my comment is misguided, since the constructor for the `DiscreteHilbertValue` class will try to take the cached value of the parent node to set `valueToInsert`.  Maybe there is still a way to refactor here but I am not so sure, so maybe there is nothing to do here.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/664/files/f9127cea62d5ce1ad8d5f59931de108a2f7cdd9b#r67933571
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160621/e66691d0/attachment.html>