<p>In <a href="https://github.com/mlpack/mlpack/pull/664#discussion_r67933571">src/mlpack/core/tree/rectangle_tree/discrete_hilbert_value.hpp</a>:</p>
<pre style='color:#555'>> + const arma::Col<HilbertElemType>* ValueToInsert() const
> + { return valueToInsert; }
> +
> + private:
> + //! The number of bits that we can store
> + static constexpr size_t order = sizeof(HilbertElemType) * CHAR_BIT;
> + //! The local dataset
> + arma::Mat<HilbertElemType>* localDataset;
> + //! Indicates that the node owns the local dataset
> + bool ownsLocalDataset;
> + //! The number of values in the local dataset
> + size_t numValues;
> + //! The Hilbert value of the point that is being inserted
> + arma::Col<HilbertElemType>* valueToInsert;
> + //! Indicates that the node owns the valueToInsert
> + bool ownsValueToInsert;
</pre>
<p>I read the code more and maybe my comment is misguided, since the constructor for the <code>DiscreteHilbertValue</code> class will try to take the cached value of the parent node to set <code>valueToInsert</code>. Maybe there is still a way to refactor here but I am not so sure, so maybe there is nothing to do here.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/664/files/f9127cea62d5ce1ad8d5f59931de108a2f7cdd9b#r67933571">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFL0NxKbysvpSMTshRWYhCth2g8Rcks5qODhGgaJpZM4IrlzT">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFGsxHy7WCnUOnGsK9TXWwqVUoBdcks5qODhGgaJpZM4IrlzT.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/664/files/f9127cea62d5ce1ad8d5f59931de108a2f7cdd9b#r67933571"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>