[mlpack-git] [mlpack/mlpack] Modify NSModel to use boost variant. (#693)

Ryan Curtin notifications at github.com
Thu Jun 16 19:36:31 EDT 2016


> @@ -37,6 +49,127 @@ struct NSModelName<FurthestNeighborSort>
>    static const std::string Name() { return "furthest_neighbor_search_model"; }
>  };
>  
> +class MonoSearchVisitor : public boost::static_visitor<void>

Ah, I hate to be picky, so I hope I am not giving too much work, but do you think you could add documentation for these classes and their members and member functions?  I am not sure everyone who looks through this file will be familiar with the visitor paradigm; there is no need to explain what that is in your comments, but it may be useful to have comments along the lines of "MonoSearchVisitor executes a monochromatic neighbor search on the given NSType", or something like this.  Maybe a few more words are useful to explain that better. :)

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/693/files/83f1925bb246471323c893b7ead2f7ebf39124b1#r67442263
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160616/a333f3f2/attachment.html>


More information about the mlpack-git mailing list