<p>In <a href="https://github.com/mlpack/mlpack/pull/693#discussion_r67442263">src/mlpack/methods/neighbor_search/ns_model.hpp</a>:</p>
<pre style='color:#555'>> @@ -37,6 +49,127 @@ struct NSModelName<FurthestNeighborSort>
> static const std::string Name() { return "furthest_neighbor_search_model"; }
> };
>
> +class MonoSearchVisitor : public boost::static_visitor<void>
</pre>
<p>Ah, I hate to be picky, so I hope I am not giving too much work, but do you think you could add documentation for these classes and their members and member functions? I am not sure everyone who looks through this file will be familiar with the visitor paradigm; there is no need to explain what that is in your comments, but it may be useful to have comments along the lines of "MonoSearchVisitor executes a monochromatic neighbor search on the given NSType", or something like this. Maybe a few more words are useful to explain that better. :)</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/693/files/83f1925bb246471323c893b7ead2f7ebf39124b1#r67442263">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFBcc71bdczeYjv-tHGTYr7sHEdKHks5qMd3_gaJpZM4I0YA9">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFJrD4pGKs_xES7E_t1JjkubuPoVSks5qMd3_gaJpZM4I0YA9.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/693/files/83f1925bb246471323c893b7ead2f7ebf39124b1#r67442263"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>