[mlpack-git] [mlpack/mlpack] edge_boxes: feature extraction updated, tests added (#696)

[Marcus Edel]

> +  const size_t n_cell = this->options["n_cell"];
> +  const size_t rgbd = this->options["rgbd"];
> +  const size_t n_orient = this->options["n_orient"];
> +  /*
> +  n_color_ch: number of color channels
> +  n_grad_ch: number of gradient channels
> +  n_ch: total number of channels
> +  */
> +  size_t n_color_ch;
> +  if (this->options["rgbd"] == 0)
> +    n_color_ch = 3;
> +  else
> +    n_color_ch = 4;
> +
> +  const size_t n_grad_ch = 2 * (1 + n_orient);
> +

To be consistent with the rest of the codebase, it would be great if you could use camel casing for all names.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/696/files/b38b688edfc4c2ee8bf461240f8384a70575d3a4#r67072983
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160614/451682f6/attachment.html>