<p>In <a href="https://github.com/mlpack/mlpack/pull/696#discussion_r67072983">src/mlpack/methods/edge_boxes/feature_extraction_impl.hpp</a>:</p>
<pre style='color:#555'>> + const size_t n_cell = this->options["n_cell"];
> + const size_t rgbd = this->options["rgbd"];
> + const size_t n_orient = this->options["n_orient"];
> + /*
> + n_color_ch: number of color channels
> + n_grad_ch: number of gradient channels
> + n_ch: total number of channels
> + */
> + size_t n_color_ch;
> + if (this->options["rgbd"] == 0)
> + n_color_ch = 3;
> + else
> + n_color_ch = 4;
> +
> + const size_t n_grad_ch = 2 * (1 + n_orient);
> +
</pre>
<p>To be consistent with the rest of the codebase, it would be great if you could use camel casing for all names.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/696/files/b38b688edfc4c2ee8bf461240f8384a70575d3a4#r67072983">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFGmlfaMBG06txFyP9n63m82_iCKFks5qLzF8gaJpZM4I1lnr">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFDvSLg_nUHeZ-REFTrz6obxAO3ALks5qLzF8gaJpZM4I1lnr.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/696/files/b38b688edfc4c2ee8bf461240f8384a70575d3a4#r67072983"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>