[mlpack-git] [mlpack/mlpack] Modify NSModel to use boost variant. (#693)

[Ryan Curtin]

> +{
> + private:
> +   const size_t k;
> +   arma::Mat<size_t>& neighbors;
> +   arma::mat& distances;
> +
> + public:
> +   template<typename NSType>
> +   void operator()(NSType *ns) const;
> +
> +   SearchKVisitor(const size_t k,
> +                  arma::Mat<size_t>& neighbors,
> +                  arma::mat& distances);
> +};
> +
> +class SearchVisitor : public boost::static_visitor<void>

Maybe we should change the name of this class and `SearchKVisitor` to `BichromaticSearchVisitor` and `MonochromaticSearchVisitor`, respectively, for clarity?  I couldn't think of any shorter names to differentiate there, but maybe you have a better idea?  The root of my concern is that `Search` and `SearchK` don't really describe the difference in what is going on.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/693/files/86a9852f19daf58e4ae5a3d3ca745deee43d8d16#r66857386
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160613/d1152c10/attachment.html>