<p>In <a href="https://github.com/mlpack/mlpack/pull/693#discussion_r66857386">src/mlpack/methods/neighbor_search/ns_model.hpp</a>:</p>
<pre style='color:#555'>> +{
> + private:
> + const size_t k;
> + arma::Mat<size_t>& neighbors;
> + arma::mat& distances;
> +
> + public:
> + template<typename NSType>
> + void operator()(NSType *ns) const;
> +
> + SearchKVisitor(const size_t k,
> + arma::Mat<size_t>& neighbors,
> + arma::mat& distances);
> +};
> +
> +class SearchVisitor : public boost::static_visitor<void>
</pre>
<p>Maybe we should change the name of this class and <code>SearchKVisitor</code> to <code>BichromaticSearchVisitor</code> and <code>MonochromaticSearchVisitor</code>, respectively, for clarity? I couldn't think of any shorter names to differentiate there, but maybe you have a better idea? The root of my concern is that <code>Search</code> and <code>SearchK</code> don't really describe the difference in what is going on.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/693/files/86a9852f19daf58e4ae5a3d3ca745deee43d8d16#r66857386">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFEm2gDRvPRs45j7NRcoTH1HpAWcUks5qLbfTgaJpZM4I0YA9">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFOtcMrkEE7OcDm622Jiga7jWNfHcks5qLbfTgaJpZM4I0YA9.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/693/files/86a9852f19daf58e4ae5a3d3ca745deee43d8d16#r66857386"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>