[mlpack-git] [mlpack/mlpack] Hilbert R tree (#664)

Ryan Curtin notifications at github.com
Sun Jun 5 01:59:51 EDT 2016


So, if there is no global dataset, anymore, then `node->Dataset()` should return the local dataset.  Then, if you want a particular column in the dataset, you can call `node->Dataset().col(node->Point(i));`.  So I don't think there is a problem there; maybe we will have to clarify the documentation in the TreeType API page and `example_tree.hpp` but that should not be difficult and should not break any existing code.

I am not sure using RecursiveHilbertValue as the only test for DiscreteHilbertValue is good, since we are not guaranteed that RecursiveHilbertValue is correct; so if you are not already planning on it, I think it would be a good idea to add a few more tests also (maybe very simple stuff, like, "the origin maps to a lower hilbert value than (1 1 1 1 ...)").


---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/664#issuecomment-223794985
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160604/b3b34a8c/attachment.html>


More information about the mlpack-git mailing list