<p>So, if there is no global dataset, anymore, then <code>node->Dataset()</code> should return the local dataset. Then, if you want a particular column in the dataset, you can call <code>node->Dataset().col(node->Point(i));</code>. So I don't think there is a problem there; maybe we will have to clarify the documentation in the TreeType API page and <code>example_tree.hpp</code> but that should not be difficult and should not break any existing code.</p>
<p>I am not sure using RecursiveHilbertValue as the only test for DiscreteHilbertValue is good, since we are not guaranteed that RecursiveHilbertValue is correct; so if you are not already planning on it, I think it would be a good idea to add a few more tests also (maybe very simple stuff, like, "the origin maps to a lower hilbert value than (1 1 1 1 ...)").</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/664#issuecomment-223794985">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFAnNLKKJNT8PTcPk8DzCtvC5uA5Sks5qImXXgaJpZM4IrlzT">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFC3wvVzp_51A2eZ_9iQNixEkYsXbks5qImXXgaJpZM4IrlzT.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/664#issuecomment-223794985"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>