[mlpack-git] [mlpack/mlpack] Hilbert R tree (#664)

[Ryan Curtin]

> +  std::list<arma::Col<uint64_t>>::iterator &LargestValue()
> +  { return largestValue; }
> +
> +  //! Modify the local dataset
> +  std::list<arma::Col<uint64_t>> *LocalDataset() { return localDataset; }
> +  //! Modify the dataset
> +  arma::Mat<uint64_t> *Dataset() { return dataset; }
> + private:
> +  //! The dataset
> +  arma::Mat<uint64_t> *dataset;
> +  //! Indicates that the node owns the dataset
> +  bool ownsDataset;
> +  //! The local dataset
> +  std::list<arma::Col<uint64_t>> *localDataset;
> +  //! The largest Hilbert value
> +  std::list<arma::Col<uint64_t>>::iterator largestValue;

I agree, you should use `arma::Mat<uint64_t>` here.  I would also say you could just store the index of the largest value with a `size_t` instead of an iterator.  It might be simpler that way.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/664/files/ab890dff6b4b617b5309af53950c6cac97d994d6#r65640851
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160602/0899f8fa/attachment-0001.html>