<p>In <a href="https://github.com/mlpack/mlpack/pull/664#discussion_r65640851">src/mlpack/core/tree/rectangle_tree/discrete_hilbert_value.hpp</a>:</p>
<pre style='color:#555'>> + std::list<arma::Col<uint64_t>>::iterator &LargestValue()
> + { return largestValue; }
> +
> + //! Modify the local dataset
> + std::list<arma::Col<uint64_t>> *LocalDataset() { return localDataset; }
> + //! Modify the dataset
> + arma::Mat<uint64_t> *Dataset() { return dataset; }
> + private:
> + //! The dataset
> + arma::Mat<uint64_t> *dataset;
> + //! Indicates that the node owns the dataset
> + bool ownsDataset;
> + //! The local dataset
> + std::list<arma::Col<uint64_t>> *localDataset;
> + //! The largest Hilbert value
> + std::list<arma::Col<uint64_t>>::iterator largestValue;
</pre>
<p>I agree, you should use <code>arma::Mat<uint64_t></code> here. I would also say you could just store the index of the largest value with a <code>size_t</code> instead of an iterator. It might be simpler that way.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/664/files/ab890dff6b4b617b5309af53950c6cac97d994d6#r65640851">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFESMnABxogd4HNSMbgYryW8hTBx2ks5qH3M9gaJpZM4IrlzT">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFNNCd2dxpvcggqN6CvkR-kMvOCwdks5qH3M9gaJpZM4IrlzT.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/664/files/ab890dff6b4b617b5309af53950c6cac97d994d6#r65640851"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>