[mlpack-git] [mlpack/mlpack] fix problem while prepending in #667 (#669)

[Ryan Curtin]

> @@ -67,23 +67,21 @@ int main(int argc, char** argv)
>    CLI::ParseCommandLine(argc, argv);
>    const string inputFile = CLI::GetParam<string>("input_file");
>    const string inputLabels = CLI::GetParam<string>("input_labels_file");
> -  string trainingFile = CLI::GetParam<string>("training_file");
> -  string testFile = CLI::GetParam<string>("test_file");
> -  string trainingLabelsFile = CLI::GetParam<string>("training_labels_file");
> -  string testLabelsFile = CLI::GetParam<string>("test_labels_file");
> +  const string trainingFile = CLI::GetParam<string>("training_file");
> +  const string testFile = CLI::GetParam<string>("test_file");
> +  const string trainingLabelsFile = CLI::GetParam<string>("training_labels_file");
> +  const string testLabelsFile = CLI::GetParam<string>("test_labels_file");
>    const double testRatio = CLI::GetParam<double>("test_ratio");
>  
>    // Check on data parameters.
>    if (trainingFile.empty())

Shouldn't this now be `if (!CLI::HasParam("training_file"))` since there's now a default value? (same for the other parameters)

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/669/files/53093b91ffa64015ef1be874e0d178966ce555a1#r65612287
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160602/6e549f91/attachment.html>