<p>In <a href="https://github.com/mlpack/mlpack/pull/669#discussion_r65612287">src/mlpack/methods/preprocess/preprocess_split_main.cpp</a>:</p>
<pre style='color:#555'>> @@ -67,23 +67,21 @@ int main(int argc, char** argv)
> CLI::ParseCommandLine(argc, argv);
> const string inputFile = CLI::GetParam<string>("input_file");
> const string inputLabels = CLI::GetParam<string>("input_labels_file");
> - string trainingFile = CLI::GetParam<string>("training_file");
> - string testFile = CLI::GetParam<string>("test_file");
> - string trainingLabelsFile = CLI::GetParam<string>("training_labels_file");
> - string testLabelsFile = CLI::GetParam<string>("test_labels_file");
> + const string trainingFile = CLI::GetParam<string>("training_file");
> + const string testFile = CLI::GetParam<string>("test_file");
> + const string trainingLabelsFile = CLI::GetParam<string>("training_labels_file");
> + const string testLabelsFile = CLI::GetParam<string>("test_labels_file");
> const double testRatio = CLI::GetParam<double>("test_ratio");
>
> // Check on data parameters.
> if (trainingFile.empty())
</pre>
<p>Shouldn't this now be <code>if (!CLI::HasParam("training_file"))</code> since there's now a default value? (same for the other parameters)</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/669/files/53093b91ffa64015ef1be874e0d178966ce555a1#r65612287">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFBfvvT_-UfJJgraakQtISgrbyr8Qks5qHzzSgaJpZM4Is6vq">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFEIo1m0c84WoZRw6qjuLCV_Mqj7uks5qHzzSgaJpZM4Is6vq.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/669/files/53093b91ffa64015ef1be874e0d178966ce555a1#r65612287"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>