[mlpack-git] [mlpack/mlpack] Vantage point tree (#708)

[lozhnikov]

> +  }
> +}
> +
> +template<typename MetricType,
> +         typename StatisticType,
> +         typename MatType,
> +         template<typename BoundMetricType, typename...> class BoundType,
> +         template<typename SplitBoundType, typename SplitMatType>
> +             class SplitType>
> +template<typename RuleType>
> +void VantagePointTree<MetricType, StatisticType, MatType, BoundType, SplitType>::
> +DualTreeTraverser<RuleType>::Traverse(
> +    const size_t queryIndex,
> +    VantagePointTree<MetricType, StatisticType, MatType, BoundType, SplitType>&
> +        referenceNode)
> +{

`SingleTreeTraverser` does not take care of `traversalInfo`. If I am not mistaken `Score(queryIndex, referenceNode)` also does not modify `traversalInfo`. So I think in order to do that we should simply add a `SingleTreeTraverser` object to `DualTreeTraverser`. But `numBaseCases` will be wrong... I should think about that.

Is it a good idea to use an inherited class here?.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/708/files/300882ac96e7a663e3e303ca0c45c14c6fafe1a6#r71907333
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160722/4e6f50a1/attachment-0001.html>