<p>In <a href="https://github.com/mlpack/mlpack/pull/708#discussion_r71907333">src/mlpack/core/tree/vantage_point_tree/dual_tree_traverser_impl.hpp</a>:</p>
<pre style='color:#555'>> + }
> +}
> +
> +template<typename MetricType,
> + typename StatisticType,
> + typename MatType,
> + template<typename BoundMetricType, typename...> class BoundType,
> + template<typename SplitBoundType, typename SplitMatType>
> + class SplitType>
> +template<typename RuleType>
> +void VantagePointTree<MetricType, StatisticType, MatType, BoundType, SplitType>::
> +DualTreeTraverser<RuleType>::Traverse(
> + const size_t queryIndex,
> + VantagePointTree<MetricType, StatisticType, MatType, BoundType, SplitType>&
> + referenceNode)
> +{
</pre>
<p><code>SingleTreeTraverser</code> does not take care of <code>traversalInfo</code>. If I am not mistaken <code>Score(queryIndex, referenceNode)</code> also does not modify <code>traversalInfo</code>. So I think in order to do that we should simply add a <code>SingleTreeTraverser</code> object to <code>DualTreeTraverser</code>. But <code>numBaseCases</code> will be wrong... I should think about that.</p>
<p>Is it a good idea to use an inherited class here?.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/708/files/300882ac96e7a663e3e303ca0c45c14c6fafe1a6#r71907333">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFNYv-pfa1xOHXxOE_D06yMj_UBDPks5qYPC0gaJpZM4I_COp">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFHWy1hzUISyhw_u-SlfUVCd9LN-Gks5qYPC0gaJpZM4I_COp.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/708/files/300882ac96e7a663e3e303ca0c45c14c6fafe1a6#r71907333"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>