[mlpack-git] [mlpack/mlpack] DatasetMapper & Imputer (#694)

[Marcus Edel]

> +    {
> +      output(target.first, target.second) = mean;
> +    }
> +  }
> +
> +  /**
> +   * Impute function searches through the input looking for mappedValue and
> +   * replaces it with the mean of the given dimension. The result is overwritten
> +   * to the input matrix.
> +   *
> +   * @param input Matrix that contains mappedValue.
> +   * @param mappedValue Value that the user wants to get rid of.
> +   * @param dimension Index of the dimension of the mappedValue.
> +   * @param columnMajor State of whether the input matrix is columnMajor or not.
> +   */
> +  void Impute(arma::Mat<T>& input,

Thanks for the clarification. So, you mean you don't have to iterate over all dimension and you can avoid:

``
output(row, col) = input(row, col);
``

in line 73? Do you think the self-assignment check is that inefficient?



---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/694/files/028c217057410e2e75691c32bf062202ce5dca3f#r71879092
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160722/0fb9c369/attachment.html>