[mlpack-git] [mlpack/mlpack] LSHSearch Parallelization (#700)

Ryan Curtin notifications at github.com
Thu Jul 7 15:55:44 EDT 2016


> @@ -733,7 +762,8 @@ void LSHSearch<SortPolicy>::ReturnIndicesFromTable(
>  
>      // Retrieve candidates.
>      size_t start = 0;
> -    for (size_t i = 0; i < numTablesToSearch; ++i) // For all tables
> +
> +    for (long long int i = 0; i < numTablesToSearch; ++i) // For all tables

The restriction to `long long` here to support Windows really irks me, and as far as I can tell there is no reasonable and portable way to get something that's the same size as `size_t` but signed (there is `ssize_t` but its support on Windows is unclear to me).  I have half a mind to just require OpenMP 3.0 support to get rid of this stupid restriction, which would disable OpenMP support with Visual Studio.  I am not sure I am bothered by that; OpenMP 3 is almost a decade old at this point and the Visual Studio team still doesn't have support for it, so I am not sure I want to keep restricting us to such a legacy version.  Windows users, if they need parallelism, can always switch to using MinGW or ICC or something like that.  What do you think?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/700/files/c4c8ff950be8a06e06084764f188095c650b7a60#r69975307
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160707/8cfb20cb/attachment.html>


More information about the mlpack-git mailing list