<p>In <a href="https://github.com/mlpack/mlpack/pull/700#discussion_r69975307">src/mlpack/methods/lsh/lsh_search_impl.hpp</a>:</p>
<pre style='color:#555'>> @@ -733,7 +762,8 @@ void LSHSearch<SortPolicy>::ReturnIndicesFromTable(
>
> // Retrieve candidates.
> size_t start = 0;
> - for (size_t i = 0; i < numTablesToSearch; ++i) // For all tables
> +
> + for (long long int i = 0; i < numTablesToSearch; ++i) // For all tables
</pre>
<p>The restriction to <code>long long</code> here to support Windows really irks me, and as far as I can tell there is no reasonable and portable way to get something that's the same size as <code>size_t</code> but signed (there is <code>ssize_t</code> but its support on Windows is unclear to me). I have half a mind to just require OpenMP 3.0 support to get rid of this stupid restriction, which would disable OpenMP support with Visual Studio. I am not sure I am bothered by that; OpenMP 3 is almost a decade old at this point and the Visual Studio team still doesn't have support for it, so I am not sure I want to keep restricting us to such a legacy version. Windows users, if they need parallelism, can always switch to using MinGW or ICC or something like that. What do you think?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/700/files/c4c8ff950be8a06e06084764f188095c650b7a60#r69975307">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFFYW8yuEglQFkBPALZpmeAhLyWwdks5qTVnAgaJpZM4I5KSz">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFHMLIQLziqEOLLmk5JJVdDBqehnGks5qTVnAgaJpZM4I5KSz.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/700/files/c4c8ff950be8a06e06084764f188095c650b7a60#r69975307"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>