[mlpack-git] [mlpack/mlpack] DatasetMapper & Imputer (#694)

[Tham]

> @@ -37,7 +37,7 @@ class DatasetMapper
>     */
>    DatasetMapper(const size_t dimensionality = 0);
>  
> -  DatasetMapper(MapPolicy policy, const size_t dimensionality = 0);
> +  DatasetMapper(PolicyType& policy, const size_t dimensionality = 0);

Do you need the ability of implicit conversion?If not, maybe we could make the constructor as explicit?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/694/files/87d8d46396a42a4cd491b32be4f17e8582c9223d..de0b2dbba2422296d801e7aa60dc2ed06091ae1a#r69373654
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160701/a0809460/attachment.html>